[
https://issues.apache.org/jira/browse/OAK-1719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jukka Zitting resolved OAK-1719.
--------------------------------
Resolution: Fixed
Fix Version/s: 1.0
Fixed a few other issues in revision 1587399, most notably by adding an editor
that adjusts {{rep:glob}} settings in ACEs to use the new {{rep:restrictions}}
structure and by fixing the {{PermissionHook}} to use the _after_ state instead
of the _before_ state for privilege bits, as otherwise newly added privileges
(all of them in an upgrade) would not be available when updating the permission
store entries of ACEs added or modified in that commit.
I also reviewed all the remaining commit hooks to verify that everything that
should be run during the upgrade is included. For example the version editor is
explicitly not included since we want to avoid automatically triggering extra
versioning changes during the upgrade. Many of the validators, like the name
and conflict ones, are also not included as other parts of the upgrade code
already take care of those issues and we want to avoid any extra duplicate work
in the already quite expensive upgrade process.
Merged the changes to the 1.0 branch in revision 1587400.
Resolving as fixed.
> Missing commit hooks in upgrade
> -------------------------------
>
> Key: OAK-1719
> URL: https://issues.apache.org/jira/browse/OAK-1719
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: upgrade
> Reporter: Jukka Zitting
> Assignee: Jukka Zitting
> Fix For: 1.0
>
>
> There's a TODO in the RepositoryUpgrade class about missing commit hooks. For
> example the PermissionHook isn't currently run as a part of the upgrade,
> which breaks permission evaluation even though the actual ACL nodes are
> present after the upgrade.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
