[ 
https://issues.apache.org/jira/browse/OAK-1751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13979544#comment-13979544
 ] 

Thomas Mueller commented on OAK-1751:
-------------------------------------

I have tested the patch, it looks good to me.

I think in the future, we will need even more tests to verify all possible code 
paths and combinations are covered. For example, the first change in 
NodeDocument.isConflicting is not tested (the "delete" case), but I don't 
currently see how it could be efficiently tested. We would need very special 
timing conditions. Maybe with a custom DocumentStore that pauses in a 
programmable way.

> DocumentNodeStore may detect conflict too late
> ----------------------------------------------
>
>                 Key: OAK-1751
>                 URL: https://issues.apache.org/jira/browse/OAK-1751
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: core, mongomk
>    Affects Versions: 0.20
>            Reporter: Marcel Reutegger
>            Assignee: Marcel Reutegger
>            Priority: Critical
>             Fix For: 1.1
>
>
> Under load and with concurrent commits to the same node it may happen that 
> the DocumentNodeStore detects a conflict too late and throws an exception 
> like this:
> {noformat}
> MicroKernelException: Unable to annotate our revision with collision marker. 
> Our revision: r1458568cc53-0-1, ...
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to