[ 
https://issues.apache.org/jira/browse/OAK-1716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chetan Mehrotra resolved OAK-1716.
----------------------------------

    Resolution: Fixed

bq. We already have two incompatible ways of handling concurrency in test 
cases, and I'm afraid that the introduced execution context complicates the 
situation even further unless we refactor the already existing benchmarks to 
consistently use it.

Not sure there. {{--concurrency}} option looks useful and was just lacking 
support for per thread context which was added with this issue and it seems to 
work well for {{FullTextSearchTest}}. A test can opt to support the concurrency 
option if usecase requires it.

Closing the issue for now. if any specific refactoring is required specific 
issues can be opened for that

> Enable passing of a execution context to runTest in multi threaded runs
> -----------------------------------------------------------------------
>
>                 Key: OAK-1716
>                 URL: https://issues.apache.org/jira/browse/OAK-1716
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: bench
>    Affects Versions: 0.20
>            Reporter: Chetan Mehrotra
>            Assignee: Chetan Mehrotra
>            Priority: Minor
>              Labels: concurrency, test
>             Fix For: 1.1
>
>
> Benchmark runner has support for specifying concurrency levels to execute the 
> test with varying level of concurrency. In most cases the test case would be 
> operating on a JCR session. With multi threaded runs we need a way to have 
> jcr session bound to that thread of execution.
> To support that {{AbstractTest}} should provide a way for client to provide a 
> executionContext object which sub classes can provide. That context would be 
> managed per thread and passed to the runTest method if not null



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to