[ 
https://issues.apache.org/jira/browse/OAK-1902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14037190#comment-14037190
 ] 

Thomas Mueller commented on OAK-1902:
-------------------------------------

We should probably ensure that by default, the node type index has a higher 
cost than a property index with, even for conditions of the type "property is 
not null".

I didn't fully review the patch yet, but what I read so far it looks good. It 
would be nice if there are additional tests on the JCR level.

> NodeTypeIndex is not conversative enough about its cost
> -------------------------------------------------------
>
>                 Key: OAK-1902
>                 URL: https://issues.apache.org/jira/browse/OAK-1902
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: query
>            Reporter: Justin Edelson
>             Fix For: 1.0.2
>
>         Attachments: OAK-1902.patch
>
>
> NodeTypeIndexProvider derives its cost from PropertyIndexLookup. 
> PropertyIndexLookup has a hardcoded maximum cost (which actually isn't a 
> maximum cost, but is more the maximum number of nodes which will be read 
> during cost calcuation).
> IMHO, these maximum costs should not be the same. In my experience with 
> JCR-based applications, the number of matches for a particular node type is 
> far greater than the number of matches for a regular property value.
> As a result, I would suggest that if the maximum cost is reached, a greater 
> penalty should be applied to a node type index than a regular property index.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to