[
https://issues.apache.org/jira/browse/OAK-1816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14041943#comment-14041943
]
Chetan Mehrotra edited comment on OAK-1816 at 6/24/14 10:19 AM:
----------------------------------------------------------------
Patch which takes the first approach by making ContentRepositoryImpl implements
Closeable. However now the calling code has to check if the returned
contentRepository is closeable and close it then upon shutdown.
The fix also resolves OAK-1485
Or we can make Oak instance statefull and have a lifecycle handling there
[~jukkaz] [~mduerig] Kindly review
was (Author: chetanm):
Patch which takes the first approach by making ContentRepositoryImpl implements
Closeable. However now the calling code has to check if the returned
contentRepository is closeable and close it then upon shutdown.
The fix also resolves OAK-1485
Or we can make Oak instance statefull and have a lifecycle handling there
> Oak#createContentRepository never unregisters some of its services
> ------------------------------------------------------------------
>
> Key: OAK-1816
> URL: https://issues.apache.org/jira/browse/OAK-1816
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: core
> Reporter: Michael Dürig
> Attachments: OAK-1816.patch
>
>
> {{Oak#createContentRepository}} registers a bunch of services with the
> {{Whiteboard}} (MBeans, Executor, Observer) that are never unregistered.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
