[ 
https://issues.apache.org/jira/browse/OAK-1816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14043554#comment-14043554
 ] 

Jukka Zitting commented on OAK-1816:
------------------------------------

+0.5 on the patch.

I think fundamentally the Oak class is growing beyond it's original design 
here, and instead of adding features like this we might be better served by not 
trying to extend it any further. As seen here, a complex deployment with lots 
of moving pieces will need more explicit lifecycle management than what the Oak 
class provides. For example in an OSGi environment it might make more sense to 
just *avoid* using the Oak class and instead directly instantiate and manage 
the various required components using the existing lifecycle management 
functionality already provided by OSGi.

> Oak#createContentRepository never unregisters some of its services
> ------------------------------------------------------------------
>
>                 Key: OAK-1816
>                 URL: https://issues.apache.org/jira/browse/OAK-1816
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: core
>            Reporter: Michael Dürig
>         Attachments: OAK-1816.patch
>
>
> {{Oak#createContentRepository}} registers a bunch of services with the 
> {{Whiteboard}} (MBeans, Executor, Observer) that are never unregistered. 



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to