[
https://issues.apache.org/jira/browse/OAK-1973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14076169#comment-14076169
]
Alex Parvulescu commented on OAK-1973:
--------------------------------------
http://svn.apache.org/viewvc/jackrabbit/oak/branches/1.0/oak-core/src/main/java/org/apache/jackrabbit/oak/spi/commit/VisibleEditor.java?r1=1611585&r2=1611584&pathrev=1611585
{code}
if (editor != null && !(editor instanceof VisibleEditor)) {
return new VisibleEditor(editor);
} else {
return null;
{code}
shouldn't this be _return editor_ instead? It looks like if you wrap a
VisibleEditor you get a null, but a better option would be to simply return the
original one.
> IndexUpdate traverses the data nodes under index nodes
> ------------------------------------------------------
>
> Key: OAK-1973
> URL: https://issues.apache.org/jira/browse/OAK-1973
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: core
> Reporter: Chetan Mehrotra
> Assignee: Chetan Mehrotra
> Fix For: 1.1, 1.0.3
>
> Attachments: OAK-1973.patch
>
>
> AsyncIndexUpdate uses IndexUpdate class as Editor and passes it to
> EditorDiff. IndexUpdate insternally wraps all the IndexEditors with
> VisibileEditor such that they do not traverse the invisible nodes (like
> :data). However IndexUpdate itself is not wrapped with VisibileEditor due to
> which it has to traverse all the Index data also for diff.
> Ideally IndexUpdate itself should be wrapped with VisibileEditor
--
This message was sent by Atlassian JIRA
(v6.2#6252)
