[ 
https://issues.apache.org/jira/browse/OAK-1977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14128511#comment-14128511
 ] 

Vikas Saurabh commented on OAK-1977:
------------------------------------

{{N}} using attached benchmark test reported {{27854}} v/s {{2729}} (tested 
with fix commit reverted and error level changed to {{error}} to avoid 
traversal warning and have fairer comparison). So, I think perf improvement is 
significant enough for the issue to be considered resolved.

Should we also not include the benchmark test too?

Also, I noticed that there is an issue while estimating cost: cost estimation 
first reads an estimated count on top of index tree. If found, it returns that 
as estimate. But, with a path restriction, that count would be wrong -- should 
we have partial traversal based cost estimation when query has path restriction?

> ContentMirrorStoreStrategy should utilize path restriction when available
> -------------------------------------------------------------------------
>
>                 Key: OAK-1977
>                 URL: https://issues.apache.org/jira/browse/OAK-1977
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: query
>    Affects Versions: 1.0.1
>            Reporter: Vikas Saurabh
>            Assignee: Thomas Mueller
>             Fix For: 1.1
>
>         Attachments: 1977-benchmark.patch, 1977-proposed.patch
>
>
> Currently {{ContentStoreMirrorStrategy}} has a mirror of content path under 
> {{:index}}. Yet, while {{query}} (and {{count}}) methods doesn't jump 
> directly into restricted path.
> This would be very useful for {{PropertyIndex}} where the queries can be 
> optimized by supplying a path restriction along with an indexed property 
> restriction (I don't know if queries with references would use paths so much 
> though)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to