[ 
https://issues.apache.org/jira/browse/OAK-2100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14135450#comment-14135450
 ] 

Alex Parvulescu commented on OAK-2100:
--------------------------------------

bq. Could you also add JavaDoc
Agreed, will do that.

bq. I'm specifically unclear on what the return value should be for a non 
existing checkpoint.
I think a good (default) behavior is to return true even if the checkpoint 
doesn't exist.
I'm mostly interested in the SegmentMk where checkpoints have a loose contract 
where the request to release a checkpoint might not actually remove it.

bq. But we should probably increase the package version.
makes sense

> Change NodeStore#release method to return a boolean
> ---------------------------------------------------
>
>                 Key: OAK-2100
>                 URL: https://issues.apache.org/jira/browse/OAK-2100
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core, segmentmk
>            Reporter: Alex Parvulescu
>            Assignee: Alex Parvulescu
>             Fix For: 1.1, 1.0.6
>
>         Attachments: OAK-2100.patch
>
>
> I'd like to change the #release method to return a boolean. This allows for 
> better checkpoint management (also affects OAK-2088).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to