[
https://issues.apache.org/jira/browse/OAK-2119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14145950#comment-14145950
]
Thomas Mueller edited comment on OAK-2119 at 9/24/14 6:02 AM:
--------------------------------------------------------------
I understand you want to change the LuceneIndex to be an AdvancedQueryIndex
because that way, the test cases don't need to be duplicated. That's a good
reason (avoiding duplicate source code). [~alex.parvulescu], are the other
reasons? The reason why I would like to not change the LuceneIndex in the 1.0
branch is to reduce the risk of bugs introduced by this change.
There are some problems with the patch, for example the AggregateIndex no
longer aggregates the cost. Also, the IndexPlan.copy method looks wrong to me.
The AggregateIndex should wrap the index plans of all calls to the LuceneIndex
in a AggregateIndexPlan, which is then re-used when running the query. That
way, no cloning is needed, and aggregation actually works as it is supposed to
work. This is a bigger change. I can implement this, but it will need some
time. Because of that, I suggest this is done first in the trunk.
was (Author: tmueller):
I understand you want to change the LuceneIndex to be an AdvancedQueryIndex
because that way, the test cases don't need to be duplicated. That's a good
reason (avoiding duplicate source code). [~alex.parvulescu], are the other
reasons? The reason why I would like to not change the LuceneIndex in the 1.0
branch is to reduce the risk of bugs introduced by this change.
There are some problems with the patch. The AggregateIndex no longer aggregates
the cost. The AggregateIndex should wrap the index plans of all calls to the
LuceneIndex in a AggregateIndexPlan, which is then re-used when running the
query. This is a bigger change. I can implement this, but it will need some
time.
> AggregateIndex should support AdvanceQueryIndex
> -----------------------------------------------
>
> Key: OAK-2119
> URL: https://issues.apache.org/jira/browse/OAK-2119
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: query
> Reporter: Chetan Mehrotra
> Fix For: 1.1, 1.0.7
>
> Attachments: OAK-2119.patch
>
>
> Currently AggregateIndex is based on FulltextQueryIndex and thus support
> default QueryIndex. With OAK-2005 LuceneIndex would be implementing the
> {{AdvanceQueryIndex}}. To support that {{AggregateIndex}} should also support
> {{AdvanceQueryIndex}} based {{FulltextQueryIndex}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
