[ 
https://issues.apache.org/jira/browse/OAK-2188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14170938#comment-14170938
 ] 

angela commented on OAK-2188:
-----------------------------

the patch looks good... the only thing that i would probably change is in 
AbstractEvaluationTest... i think i would omit the following assertion as it is 
only relevant for the versionmanagementtest.

+        // but must not see version storage node
+        assertFalse(testSession.itemExists("/jcr:system/jcr:versionStorage"));




> Add/remove version label fails with restricted access on /jcr:system
> --------------------------------------------------------------------
>
>                 Key: OAK-2188
>                 URL: https://issues.apache.org/jira/browse/OAK-2188
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: core, jcr
>    Affects Versions: 1.0.7, 1.1.1
>            Reporter: Marcel Reutegger
>            Assignee: Marcel Reutegger
>             Fix For: 1.0.8, 1.1.2
>
>         Attachments: OAK-2188.patch
>
>
> Some version operations rely on visibility of /jcr:system/jcr:versionStorage. 
> This applies to add/remove label and remove version operations. The current 
> implementation sets a well defined property on the jcr:versionStorage node. A 
> commit hook picks up this change, removes the property again and performs the 
> requested operation on the version store.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to