[ 
https://issues.apache.org/jira/browse/OAK-2240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14190054#comment-14190054
 ] 

Thomas Mueller commented on OAK-2240:
-------------------------------------

I'm not familiar with this part of the Lucene index. A few things I noticed:

Minor: isRelativeProperty also checks "!PathUtils.isAbsolute". How can an 
absolute path be indexed... I think it would be better to reject absolute path 
and other strange property names (empty names for example).

Minor: there is a strange test "bool()", could be removed (it has a System.out).

> Support for indexing relative properties
> ----------------------------------------
>
>                 Key: OAK-2240
>                 URL: https://issues.apache.org/jira/browse/OAK-2240
>             Project: Jackrabbit Oak
>          Issue Type: Sub-task
>          Components: oak-lucene
>            Reporter: Chetan Mehrotra
>            Assignee: Chetan Mehrotra
>             Fix For: 1.0.8, 1.2
>
>         Attachments: OAK-2240.patch
>
>
> Lucene property index needs to support following queries which make use of 
> relative properties
> {noformat}
> select [jcr:path], [jcr:score], * from [dam:Asset] as a 
> where [jcr:content/jcr:lastModified] > cast('2014-10-01T00:00:00.000+02:00' 
> as date)
> {noformat}
> Possible Approach
> # Have the index definition define a property like foo/bar
> # LuceneIndexEditor would also index child property foo/bar as part of parent 
> node if present
> # On update in child the child node can indicate the parent to make the 
> document again
> # On query side the property restriction can be used listerall i.e. foo/bar 
> and stuff should work fine



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to