[ 
https://issues.apache.org/jira/browse/OAK-2282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14242140#comment-14242140
 ] 

Chetan Mehrotra edited comment on OAK-2282 at 12/11/14 4:59 AM:
----------------------------------------------------------------

After switching to new implementation and allowing all test to run (removing 
ignores in pom.xml to see which all test have started passing with newer impl)

In total 14 test pass

{noformat}
org.apache.jackrabbit.core.observation.ShareableNodesTest#testAddShare
org.apache.jackrabbit.core.observation.ShareableNodesTest#testRemoveShare
org.apache.jackrabbit.core.query.QueryResultTest#testGetSize
org.apache.jackrabbit.core.query.QueryResultTest#testGetSizeOrderByScore
org.apache.jackrabbit.core.query.QueryResultTest#testIteratorNext
org.apache.jackrabbit.core.query.QueryResultTest#testIteratorNextOrderByScore
org.apache.jackrabbit.core.query.QueryResultTest#testSkipOrderByProperty
org.apache.jackrabbit.core.query.SQL2NodeLocalNameTest#testLowerLocalNameOrContains
org.apache.jackrabbit.core.query.SQL2NodeLocalNameTest#testUpperLocalNameOrContains
org.apache.jackrabbit.core.query.SQL2OrderByTest#testOrderByScore
org.apache.jackrabbit.core.query.SimilarQueryTest#testSimilar
org.apache.jackrabbit.core.query.SimpleQueryTest#testDoubleField
org.apache.jackrabbit.core.query.SimpleQueryTest#testLongField
org.apache.jackrabbit.core.query.SimpleQueryTest#testNegativeNumber
{noformat}

Following have been enabled again
# Folowing are passing due to changes done in OAK-484 
## org.apache.jackrabbit.core.query.QueryResultTest#testGetSize
## org.apache.jackrabbit.core.query.QueryResultTest#testGetSizeOrderByScore
## org.apache.jackrabbit.core.query.QueryResultTest#testIteratorNext
## org.apache.jackrabbit.core.query.QueryResultTest#testIteratorNextOrderByScore
## org.apache.jackrabbit.core.query.QueryResultTest#testSkipOrderByProperty
# org.apache.jackrabbit.core.query.SQL2OrderByTest#testOrderByScore - This 
currently passes because Oak Core would do the sorting. However with OAK-2295 
it should continue to pass. So enabling this now //[~amitjain]
# org.apache.jackrabbit.core.query.SimilarQueryTest#testSimilar - Dependent on 
OAK-319 which is now resolved and testcase also passes. 
# Following are passing due to support for numeric field
## org.apache.jackrabbit.core.query.SimpleQueryTest#testDoubleField
## org.apache.jackrabbit.core.query.SimpleQueryTest#testLongField
## org.apache.jackrabbit.core.query.SimpleQueryTest#testNegativeNumber
# Following were related to minimal workspace support OAK-118 which has been 
partially implemented and testcase pass
## org.apache.jackrabbit.core.observation.ShareableNodesTest#testAddShare
## org.apache.jackrabbit.core.observation.ShareableNodesTest#testRemoveShare



was (Author: chetanm):
After switching to new implementation and allowing all test to run (removing 
ignores in pom.xml to see which all test have started passing with newer impl)

In total 14 test pass

{noformat}
org.apache.jackrabbit.core.observation.ShareableNodesTest#testAddShare
org.apache.jackrabbit.core.observation.ShareableNodesTest#testRemoveShare
org.apache.jackrabbit.core.query.QueryResultTest#testGetSize
org.apache.jackrabbit.core.query.QueryResultTest#testGetSizeOrderByScore
org.apache.jackrabbit.core.query.QueryResultTest#testIteratorNext
org.apache.jackrabbit.core.query.QueryResultTest#testIteratorNextOrderByScore
org.apache.jackrabbit.core.query.QueryResultTest#testSkipOrderByProperty
org.apache.jackrabbit.core.query.SQL2NodeLocalNameTest#testLowerLocalNameOrContains
org.apache.jackrabbit.core.query.SQL2NodeLocalNameTest#testUpperLocalNameOrContains
org.apache.jackrabbit.core.query.SQL2OrderByTest#testOrderByScore
org.apache.jackrabbit.core.query.SimilarQueryTest#testSimilar
org.apache.jackrabbit.core.query.SimpleQueryTest#testDoubleField
org.apache.jackrabbit.core.query.SimpleQueryTest#testLongField
org.apache.jackrabbit.core.query.SimpleQueryTest#testNegativeNumber
{noformat}

Of them however

5 test pass but are related to OAK-484. Looking at bug details I think they 
might fail intermittently as the order is not deterministic. So would leave 
them ignored for now

# org.apache.jackrabbit.core.query.QueryResultTest#testGetSize
# org.apache.jackrabbit.core.query.QueryResultTest#testGetSizeOrderByScore
# org.apache.jackrabbit.core.query.QueryResultTest#testIteratorNext
# org.apache.jackrabbit.core.query.QueryResultTest#testIteratorNextOrderByScore
# org.apache.jackrabbit.core.query.QueryResultTest#testSkipOrderByProperty

Following 8 have been enabled again

# org.apache.jackrabbit.core.query.SQL2OrderByTest#testOrderByScore - This 
currently passes because Oak Core would do the sorting. However with OAK-2295 
it should continue to pass. So enabling this now //[~amitjain]
# org.apache.jackrabbit.core.query.SimilarQueryTest#testSimilar - Dependent on 
OAK-319 which is now resolved and testcase also passes. 
# Following are passing due to support for numeric field
## org.apache.jackrabbit.core.query.SimpleQueryTest#testDoubleField
## org.apache.jackrabbit.core.query.SimpleQueryTest#testLongField
## org.apache.jackrabbit.core.query.SimpleQueryTest#testNegativeNumber
# Following were related to minimal workspace support OAK-118 which has been 
partially implemented and testcase pass
## org.apache.jackrabbit.core.observation.ShareableNodesTest#testAddShare
## org.apache.jackrabbit.core.observation.ShareableNodesTest#testRemoveShare


> Make current testcases pass with new index implementation
> ---------------------------------------------------------
>
>                 Key: OAK-2282
>                 URL: https://issues.apache.org/jira/browse/OAK-2282
>             Project: Jackrabbit Oak
>          Issue Type: Sub-task
>          Components: oak-lucene
>            Reporter: Chetan Mehrotra
>            Assignee: Chetan Mehrotra
>             Fix For: 1.2
>
>
> Current testcases in oak-lucene should be run against the newer index and all 
> such testcases should pass



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to