[
https://issues.apache.org/jira/browse/OAK-2449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14296856#comment-14296856
]
Michael Dürig commented on OAK-2449:
------------------------------------
Yes this should definitely be {{CleanupType.CLEAN_ALL}} for the offline case.
Old segments only mean something in the online case.
> offline compaction (via oak-run) broken
> ---------------------------------------
>
> Key: OAK-2449
> URL: https://issues.apache.org/jira/browse/OAK-2449
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: run
> Affects Versions: 1.1.5
> Reporter: Stefan Egli
> Attachments: compaction.patch
>
>
> This is a likely regression introduced with OAK-2192: when doing offline
> compaction via oak-run with a current oak trunk, the compaction never
> finishes - instead it creates tar file after tar file - basically filling up
> the disk if you dont stop it.
> It looks like oak-run's Main.compact() does not set the newly (in OAK-2192)
> added compactionStrategy - instead, compactionStrategy is set to
> NO_COMPACTION - which returns false when being asked if compaction is
> finished (compacted()) - which is why it just loops - and in each loop add a
> bit to the store.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
