[
https://issues.apache.org/jira/browse/OAK-2464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14301129#comment-14301129
]
Marcel Reutegger commented on OAK-2464:
---------------------------------------
Thanks for the patch.
I would probably not add another flag to Children. As you write, the decision
can already be made with the cache key and the hasMore flag. If we keep it,
then I would rather invert the default. I think the majority of the Children
entries are small and therefore complete.
The second test does not dispose the store.
Other than that, the patch looks good to me.
bq. expose MemoryDocumentStore's asMap method as protected
I think that's fine. This implementation is for testing purpose only.
> Optimize read of known non-existing children
> --------------------------------------------
>
> Key: OAK-2464
> URL: https://issues.apache.org/jira/browse/OAK-2464
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Reporter: Vikas Saurabh
> Priority: Minor
> Attachments:
> 0001-OAK-2464-Optimize-read-of-known-non-existing-childre.patch,
> OAK-2464-Sort order test case.patch, OAK-2464-Take2.patch
>
>
> Reading a non-existing node always queries down to {{DocumentStore}}.
> {{DocumentNodeStore}} should consider {{nodeChildrenCache}} to see if it
> already knows about non-existence and avoid a look up into {{DocumentStore}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
