[
https://issues.apache.org/jira/browse/OAK-2490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14316234#comment-14316234
]
Chetan Mehrotra commented on OAK-2490:
--------------------------------------
Over all patch looks fine. However placing the {{isAccessible}} call in
{{SelectorImpl}} does not look like a right place. {{SelectorImpl}} (being an
impl) looks like an implementation detail of QueryEngine and probably should
not have been exposed as part of {{Filter}} API but was added later with
OAK-1965 for some optimized handling of or cases and is currently (IIRC) is
only being used in {{PropertyIndex}}.
So instead of promoting its use it would be better if we introduce a new method
in {{Filter}} and let index implementation make use of that
> Make it possible to use the PermissionProvider from within query indexes
> ------------------------------------------------------------------------
>
> Key: OAK-2490
> URL: https://issues.apache.org/jira/browse/OAK-2490
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: core
> Reporter: Tommaso Teofili
> Assignee: Tommaso Teofili
> Fix For: 1.1.7
>
> Attachments: OAK-2490.0.patch, OAK-2490.1.patch
>
>
> As discussed on OAK-2423 and OAK-2473 it's useful to have a
> {{PermissionProvider}} down into {{QueryIndex}} implementations and/or
> {{SelectorImpl}}, depending on wether the ACL checks have to be done on an
> implementation base or generally.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
