[ 
https://issues.apache.org/jira/browse/OAK-2225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14323957#comment-14323957
 ] 

angela commented on OAK-2225:
-----------------------------

IMO the problem is that upon tear down only ACEs are being restored instead of 
having the complete policy removed in case there wasn't one before.

> MultipleMoveTest doesn't restore ACEs properly causing later tests to fail
> --------------------------------------------------------------------------
>
>                 Key: OAK-2225
>                 URL: https://issues.apache.org/jira/browse/OAK-2225
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: jcr
>         Environment: http://ci.apache.org/builders/oak-trunk
>            Reporter: Michael Dürig
>            Assignee: angela
>
> {{MultipleMoveTest}} uses {{AbstractEvaluationTest#allow()}} on 
> {{/testroot}}. However during tear-down the ACEs on that node aren't property 
> restored as {{AbstractEvaluationTest#restoreAces}} acts on 
> {{/testroot/node1}} instead of {{testroot}}. This causes later tests to fail:
> {code}
> testRename(org.apache.jackrabbit.oak.jcr.JackrabbitNodeTest)  Time elapsed: 
> 0.291 sec  <<< FAILURE!
> junit.framework.ComparisonFailure: expected:<[a]> but was:<[rep:policy]>
>       at junit.framework.Assert.assertEquals(Assert.java:85)
>       at junit.framework.Assert.assertEquals(Assert.java:91)
>       at 
> org.apache.jackrabbit.oak.jcr.JackrabbitNodeTest.testRename(JackrabbitNodeTest.java:74)
> {code}
> and 
> {code}
> testRenameEventHandling(org.apache.jackrabbit.oak.jcr.JackrabbitNodeTest)  
> Time elapsed: 0.073 sec  <<< ERROR!
> javax.jcr.nodetype.ConstraintViolationException: Item is protected.
>       at 
> org.apache.jackrabbit.oak.jcr.session.ItemImpl$ItemWriteOperation.checkPreconditions(ItemImpl.java:99)
>       at 
> org.apache.jackrabbit.oak.jcr.delegate.SessionDelegate.perform(SessionDelegate.java:233)
>       at 
> org.apache.jackrabbit.oak.jcr.session.ItemImpl.perform(ItemImpl.java:113)
>       at 
> org.apache.jackrabbit.oak.jcr.session.NodeImpl.rename(NodeImpl.java:1426)
>       at 
> org.apache.jackrabbit.oak.jcr.JackrabbitNodeTest.testRenameEventHandling(JackrabbitNodeTest.java:124)
> {code}
> See http://ci.apache.org/builders/oak-trunk/builds/664



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to