[ 
https://issues.apache.org/jira/browse/OAK-2589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14353051#comment-14353051
 ] 

Alex Parvulescu commented on OAK-2589:
--------------------------------------

+1 looks good

bq. Would it be fine to report for every 1000
I find that low, I'd opt for 10k even, less noise is best, does it help in any 
way to have this much granularity in the logs?

bs. Add javadoc to indexUpdate in IndexUpdateCallback to call out that this 
should be invoked mostly when an entry is made to the index.
Agreed, makes perfect sense


> Provide progress indication when reindexing is being peformed
> -------------------------------------------------------------
>
>                 Key: OAK-2589
>                 URL: https://issues.apache.org/jira/browse/OAK-2589
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core
>            Reporter: Chetan Mehrotra
>            Assignee: Chetan Mehrotra
>             Fix For: 1.1.8, 1.0.13
>
>         Attachments: OAK-2589.patch
>
>
> When reindex property of an oak:QueryIndexDefinition node is set to "true" 
> there is a message logged which says:
> 29.09.2014 15:04:08.904 *INFO* [pool-9-thread-3] 
> org.apache.jackrabbit.oak.plugins.index.IndexUpdate Reindexing would be 
> performed for following indexes [/oak:index/searchFacets]
> However, after that, there is no indication of progress for this reindexing. 
> The only way to determine if the reindexing is progressing is to check back 
> and see that the reindex property on your oak:QueryIndexDefinition node is 
> now set to false.
> If something goes wrong with the reindexing it is hard to know if the 
> reindexing is happening at all. 
> If there could be some logging to indicate that this reindexing is happening 
> successfully and how complete it is, it would be of a great help while 
> troubleshooting indexing problems.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to