[
https://issues.apache.org/jira/browse/OAK-2413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14355144#comment-14355144
]
Michael Dürig commented on OAK-2413:
------------------------------------
bq. is there an easy way to identify if there are changes?
If you don't need the diff, just use {{equals}}.
Re. a test: just call {{PrivilegeValidator#childNodeChanged}} directly from a
unit test passing the same node state for {{before}} and {{after}}.
> Clarify Editor.childNodeChanged()
> ---------------------------------
>
> Key: OAK-2413
> URL: https://issues.apache.org/jira/browse/OAK-2413
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: core
> Reporter: Marcel Reutegger
> Assignee: Michael Dürig
> Priority: Minor
> Fix For: 1.2
>
>
> The current contract for {{Editor.childNodeChanged()}} does not specify if
> this method may also be called when the child node did not actually change.
> The method {{NodeStateDiff.childNodeChanged()}} explicitly states that there
> may be such calls. Looking at the implementation connecting the two classes,
> {{EditorDiff.childNodeChange()}} simply calls the editor without checking
> whether the child node did in fact change.
> I think we either have to change the {{EditorDiff}} or update the contract
> for the Editor and adjust implementations. E.g. right now, PrivilegeValidator
> (implements Editor), assumes a call to {{childNodeChange()}} indeed means the
> child node changed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
