[ 
https://issues.apache.org/jira/browse/OAK-2392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14362900#comment-14362900
 ] 

Marcel Reutegger commented on OAK-2392:
---------------------------------------

I think it's better to implement this as part of the revision GC. This way, the 
blob GC can focus on cleaning up the blobs only. Linked this issue to OAK-1981.

> [DocumentMK] Garbage Collect older revisions of binary properties in main 
> document
> ----------------------------------------------------------------------------------
>
>                 Key: OAK-2392
>                 URL: https://issues.apache.org/jira/browse/OAK-2392
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: mongomk
>            Reporter: Chetan Mehrotra
>            Assignee: Chetan Mehrotra
>            Priority: Minor
>             Fix For: 1.2
>
>
> Current GC logic for DocumentMK only collects certain types of garbage (see 
> OAK-1981) and currently only split documents are removed. While complete full 
> blow gc would take time and yet not fully implemented we should handle those 
> documents which have binary properties and those properties get updated few 
> times (but not very frequently).
> For e.g. performing a reindex for Lucene index would lead to removal of index 
> files nodes and again creation of nodes with same name. In such a case the 
> older revision of binary property would remain in main document and would not 
> be eligible for gc as per current impl.
> As a fix the GC logic should look for document which might have binaries and 
> then remove the older revisions of binary properties. Currently we do scan 
> all such documents for Blob GC.
> So this can be done either as part of Revision GC or Blob GC



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to