[
https://issues.apache.org/jira/browse/OAK-2609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14363255#comment-14363255
]
Michael Dürig edited comment on OAK-2609 at 3/16/15 2:40 PM:
-------------------------------------------------------------
I don't think we should do anything here on the Oak side as we are dealing with
[documented side
effects|http://docs.oracle.com/javase/7/docs/api/java/nio/channels/InterruptibleChannel.html]
of {{Thread.interrupt}}. We should rather discourage the usage of
{{Thread.interrupt}} as:
* it is overloaded in multiple unpredictable ways,
* {{catch (InterruptedException ignore)}} is prevalent (and usually wrong),
* in most cases it breaks separation of concerns (concurrency vs. business
logic).
We should instead provide guidance to users how to best replace usages of
{{Thread.interrupt}} by safer alternatives.
OTOH fixing this in Oak means concealing deeper issues and depending on your
POV event breaking above general contract on channels.
was (Author: mduerig):
I don't think we should do anything here on the Oak side as we are dealing with
[documented side
effects|http://docs.oracle.com/javase/7/docs/api/java/nio/channels/InterruptibleChannel.html]
of {{Thread.interrupt}}:
> Thread.interrupt seems to stop repository
> -----------------------------------------
>
> Key: OAK-2609
> URL: https://issues.apache.org/jira/browse/OAK-2609
> Project: Jackrabbit Oak
> Issue Type: Bug
> Affects Versions: 1.1.7
> Environment: Java 7
> Reporter: Carsten Ziegeler
> Priority: Critical
> Fix For: 1.1.8, 1.0.13
>
>
> We have a sporadic problem with Sling's JCR installer 3.3.8 and Oak (tar mk).
> It seems to timing related: the JCR installer does a Thread#interrupt at one
> point and sometimes this brings the hole instance to stop. Nothing else is
> going on any more.
> While of course, a workaround is to remove the Thread.interrupt call in the
> JCR installer (which we did, see SLING-4477), I have the fear that this can
> happen with any code that is using the repository and gets interrupted.
> This error is hard to reproduce, however with three people testing we could
> see this several times happening
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
