[
https://issues.apache.org/jira/browse/OAK-2641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14388719#comment-14388719
]
angela commented on OAK-2641:
-----------------------------
[~tmueller], yes that would be good. IMO the second patch is better; as far as
i could see without being an expert in this area the first one might lead to
NPE as some callers rely on the affected methods to never return null... but in
general it's a bit confusing with those extra static methods that may return
null and the interface that never returns null :-)
> FilterImpl violates nullability contract
> -----------------------------------------
>
> Key: OAK-2641
> URL: https://issues.apache.org/jira/browse/OAK-2641
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: core
> Reporter: Michael Dürig
> Labels: technical_debt
> Fix For: 1.2
>
> Attachments: OAK-2641.patch, OAK-2641_2.patch
>
>
> {{FilterImpl#getSupertypes}}, {{FilterImpl#getPrimaryTypes}} and
> {{FilterImpl#getMixinTypes}} might all return {{null}} although {{Filter}}'s
> contract mandates \@Nonull.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
