[ 
https://issues.apache.org/jira/browse/OAK-2798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14506791#comment-14506791
 ] 

Chetan Mehrotra commented on OAK-2798:
--------------------------------------

Patch looks fine to me. May be we add support for AlreadyClosedException etc 
but I think that can be done as part of OAK-2799

> OakIndexInput should unset OakIndexFile's byte[] upon close
> -----------------------------------------------------------
>
>                 Key: OAK-2798
>                 URL: https://issues.apache.org/jira/browse/OAK-2798
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: lucene
>    Affects Versions: 1.2.1
>            Reporter: Tommaso Teofili
>             Fix For: 1.3.0, 1.2.2, 1.0.14
>
>         Attachments: OAK-2798.patch
>
>
> {{OakIndexInput}}, being an extension of Lucene's {{IndexInput}} implements 
> {{Closable}}, however upon {{#close}} the referenced {{OakIndexFile}}'s 
> _byte[]_ is not unset.
> This can lead to memory leak as when IndexInputs gets closed, e.g. by 
> {{StoredFieldsReaders}} such references won't be properly cleared (with 
> probably a higher impact in cases where _copyOnRead = true_). 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to