[ 
https://issues.apache.org/jira/browse/OAK-2749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14513576#comment-14513576
 ] 

Chetan Mehrotra commented on OAK-2749:
--------------------------------------

Overall approach looks good!. Minor comments

# {{AsyncIndexStats}} would need to extend the {{AnnotatedStandardMBean}} for 
those Name and Description annotation to get pickedup
# Introduce a IndexMBeanRegistrar which manages the mean registration which is 
currently duplicated between Oak and AsyncIndexUpdate. It can be passed Oak to 
AsyncIndexUpdate and thus can hook into the Oak shutdown call. With this you 
can do away with passing of Whiteboard instance
# Any specific reason to pass TaskSplitter to Mbean instance instead of letting 
it get referred from parent (host) class and also avoid the null checks

> Provide a "different lane" for slow indexers in async indexing
> --------------------------------------------------------------
>
>                 Key: OAK-2749
>                 URL: https://issues.apache.org/jira/browse/OAK-2749
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core
>            Reporter: Davide Giannella
>            Assignee: Alex Parvulescu
>             Fix For: 1.3.0
>
>         Attachments: OAK-2749-rc1.diff, OAK-2749-rc2.diff, OAK-2749-v3.diff, 
> OAK-2749-v4.diff
>
>
> In case of big repositories, asynchronous index like Lucene Property,
> could lag behind as slow indexes, for example Full Text, are taken
> care in the same thread pool.
> Provide a separate thread pool in which such indexes could be
> registered.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to