[
https://issues.apache.org/jira/browse/OAK-2599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14513808#comment-14513808
]
Chetan Mehrotra edited comment on OAK-2599 at 4/27/15 9:47 AM:
---------------------------------------------------------------
bq. One thing that could be optimised is to pass the filter down the tree and
adapting it to the respective branch instead of keeping it in the context.
Yup that can be done. However as it would add more complexity to the
implementation I avoided doing that for now. If it turns out to be problamatic
we can move to this approach
bq. Also PathFilter#optimise could be further optimised by removing entries
that subsume each other (e.g. including /a/b, /a is the same as including (/a.
Ack. Would do that
bq. Then that method is a duplicate of ObservationManagerImpl#optimise and it
would be nice if we could keep things DRY
Thast was bothering me also but not able to think of good place to keep this.
Would PathUtils be a good place? Would open a separate Task (OAK-2814) for that
to keep a track of this and something we can tackle later in trunk
was (Author: chetanm):
bq. One thing that could be optimised is to pass the filter down the tree and
adapting it to the respective branch instead of keeping it in the context.
Yup that can be done. However as it would add more complexity to the
implementation I avoided doing that for now. If it turns out to be problamatic
we can move to this approach
bq. Also PathFilter#optimise could be further optimised by removing entries
that subsume each other (e.g. including /a/b, /a is the same as including (/a.
Ack. Would do that
bq. Then that method is a duplicate of ObservationManagerImpl#optimise and it
would be nice if we could keep things DRY
Thast was bothering me also but not able to think of good place to keep this.
Would PathUtils be a good place? Would open a separate Task for that to keep a
track of this and something we can tackle later in trunk
> Allow excluding certain paths from getting indexed for particular index
> -----------------------------------------------------------------------
>
> Key: OAK-2599
> URL: https://issues.apache.org/jira/browse/OAK-2599
> Project: Jackrabbit Oak
> Issue Type: New Feature
> Components: core
> Reporter: Chetan Mehrotra
> Fix For: 1.3.0
>
> Attachments: OAK-2599-1.patch
>
>
> Currently an {{IndexEditor}} gets to index all nodes under the tree where it
> is defined (post OAK-1980). Due to this IndexEditor would traverse the whole
> repo (or subtree if configured in non root path) to perform reindex.
> Depending on the repo size this process can take quite a bit of time. It
> would be faster if an IndexEditor can exclude certain paths from traversal
> Consider an application like Adobe AEM and an index which only index
> dam:Asset or the default full text index. For a fulltext index it might make
> sense to avoid indexing the versionStore. So if the index editor skips such
> path then lots of redundant traversal can be avoided.
> Also see http://markmail.org/thread/4cuuicakagi6av4v
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
