[
https://issues.apache.org/jira/browse/OAK-2960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14576611#comment-14576611
]
Amit Jain commented on OAK-2960:
--------------------------------
bq. The difference is the presence of the @Modified method itself.
It is also present in the DocumentNodeStoreService as I mentioned above
bq. This doesn't mean that the DocumentStore, the BlobStore and everything
doesn't have to be finalized and reinitialized. It just needs to be done when
some "critical" properties change.
Why? Is it required by the specification, asking as I don't know.
bq. This is the reason why I think that OAK-2016 is wrong. It doesn't fully
implement this strategy. As it is, it may be safer to just go through a
complete cycle of deactivated() and activated() callbacks.
Well, the current implementations do just that but in addition also do update
some non-critical properties (via the @Modified) method.
[~chetanm] wdyt? Are the current implementations in
Document/SegmentNodeStoreService a problem?
> SegmentNodeStoreService doesn't fully implement a @Modified method
> ------------------------------------------------------------------
>
> Key: OAK-2960
> URL: https://issues.apache.org/jira/browse/OAK-2960
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: segmentmk
> Reporter: Francesco Mari
> Priority: Critical
> Fix For: 1.3.0
>
> Attachments: OAK-2960-01.patch
>
>
> The {{SegmentNodeStoreService}} component recently introduced an
> {{@Modified}} method that picks up changes in just one configuration property
> and ignores the rest.
> Some configuration properties, like {{customBlobStore}}, have a huge impact
> on the dynamic behaviour of the component. If the component fails to pick up
> these changes, its behaviour is just wrong.
> The {{@Modified}} method should be removed. It is safer to go through a
> complete deactivation and activation process.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
