[ 
https://issues.apache.org/jira/browse/OAK-3020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14599348#comment-14599348
 ] 

Amit Jain commented on OAK-3020:
--------------------------------

My understanding of the issue is that the exceptions are to be handled in the 
{{LuceneIndexEditor#addOrUpdate}}. So :
* We can probably catch the {{IllegalArgumentException}} [1] as it most likely 
is an application issue. 
* The {{IOException}} indicates a lucene issue should be thrown. 
* Not sure about {{CommitFailedException}}, it has to be handled for the 
{{indexAggregates}} method. 

[1]
{code}
<+>UTF-8
===================================================================
--- 
oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/LuceneIndexEditor.java
      (date 1435134534000)
+++ 
oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/LuceneIndexEditor.java
      (revision )
@@ -297,8 +297,7 @@
             throw new CommitFailedException("Lucene", 3,
                     "Failed to index the node " + path, e);
         } catch (IllegalArgumentException ie) {
-            throw new CommitFailedException("Lucene", 3,
-                "Failed to index the node " + path, ie);
+            log.warn("Lucene failed to index the node " + path, ie);
         }
         return false;
     }
{code}

> Async Update fails after IllegalArgumentException
> -------------------------------------------------
>
>                 Key: OAK-3020
>                 URL: https://issues.apache.org/jira/browse/OAK-3020
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>    Affects Versions: 1.2.2
>            Reporter: Julian Sedding
>            Assignee: Amit Jain
>             Fix For: 1.3.2
>
>         Attachments: OAK-3020-stacktrace.txt, OAK-3020.test.patch
>
>
> The async index update can fail due to a mismatch between an index definition 
> and the actual content. If that is the case, it seems that it can no longer 
> make any progress. Instead it re-indexes the latest changes over and over 
> again until it hits the problematic property.
> Discussion at http://markmail.org/thread/42bixzkrkwv4s6tq
> Stacktrace attached.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to