[
https://issues.apache.org/jira/browse/OAK-3052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14616582#comment-14616582
]
Michael Dürig commented on OAK-3052:
------------------------------------
Patch looks good, thanks for taking this up!
Just a minor nitpick, let's remove 'public' from the new interface methods as
this is implied.
Regarding the compaction estimate value: this is a percentage right? Is that
clear enough or do we need to state this more explicitly (e.g. in
{{SegmentNodeStoreService}})?
> Make compaction gain estimate threshold configurable
> ----------------------------------------------------
>
> Key: OAK-3052
> URL: https://issues.apache.org/jira/browse/OAK-3052
> Project: Jackrabbit Oak
> Issue Type: Sub-task
> Components: segmentmk
> Reporter: Michael Dürig
> Assignee: Michael Dürig
> Priority: Minor
> Labels: compaction, gc
> Fix For: 1.3.3
>
> Attachments: OAK-3052.patch
>
>
> Currently compaction is skipped if the compaction gain estimator determines
> that less than 10% of space could be reclaimed. Instead of relying on a hard
> coded value of 10% we should make this configurable.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
