[ 
https://issues.apache.org/jira/browse/OAK-3087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14620087#comment-14620087
 ] 

Marcel Reutegger commented on OAK-3087:
---------------------------------------

bq. Can you review if the approach to validate (more like a guess) whats the 
value for type field is

How about a white list of known types and then consider it disabled if it 
doesn't match any of the known types?

> [oak-mongo.js] Add utility to cleanup hidden structure under disabled indices
> -----------------------------------------------------------------------------
>
>                 Key: OAK-3087
>                 URL: https://issues.apache.org/jira/browse/OAK-3087
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: mongomk
>            Reporter: Vikas Saurabh
>            Priority: Minor
>         Attachments: 
> 0001-update-removeDescendantsAndSelf-for-upwards-removal.patch, 
> 0002-OAK-3087-Add-some-methods-to-find-disabled-indices-a.patch, 
> cleanupDisbaledIndices-take2.patch, removeDescendantsAndSelf-api-take2.patch
>
>
> While disabling property indices, avoids usage of those indices. But, they 
> still maintain the data already stored under them. That data would keep on 
> consuming storage space without serving any purpose. Also, it'd pile on 
> mongo's id index.
> While one can delete index definition node to clear these nodes up -- but, 
> it'd be really slow and a JCR based deleted would first create a HUGE commit 
> while marking all documents under it as deleted. And, then the actual 
> deletion would happen in next revision GC after 24 hours have past.
> Hence, it might be beneficial to have a low level api in oak-mongo.js, which 
> simply removes the document from mongo altogether.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to