[ 
https://issues.apache.org/jira/browse/OAK-3153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14655065#comment-14655065
 ] 

Thomas Mueller commented on OAK-3153:
-------------------------------------

> Then we could just introduce a threshold option

Sounds like a good idea. I would use make the threshold configurable, so that 0 
matches the current behavior, but with a default value of 1000.

If the goal is that each login has a logout, as it was the case for Jackrabbit 
2.x, then using a simple AtomicInteger to count open sessions is good enough. 
If we officially say that "logout is not needed", then we would need to either 
use a finalize method, or use a PhantomReference as above, where there 
PhantomReference solution is faster.

> Make it possible to disable recording of stack trace in SessionStats
> --------------------------------------------------------------------
>
>                 Key: OAK-3153
>                 URL: https://issues.apache.org/jira/browse/OAK-3153
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 1.3.3
>            Reporter: Joel Richard
>              Labels: performance
>
> For the rendering of some pages we have to create a lot of sessions. Around 
> 9% of the rendering time is spent inside of RepositoryImpl.login. Half of 
> this time is spent creating the exception in SessionStats. Therefore, it 
> would be useful if the recording of the exception could be disabled to 
> improve the performance.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to