[jira] [Commented] (OAK-3231) Change default maxCachedBinarySize to match OakDirectory#DEFAULT_BLOB_SIZE

[Chetan Mehrotra (JIRA)]

    [ 
https://issues.apache.org/jira/browse/OAK-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14696731#comment-14696731
 ] 

Chetan Mehrotra commented on OAK-3231:
--------------------------------------

This needs to be set at IndexDefinition level. Once set any new index file that 
gets created would make use of the new size otherwise it uses the default size 
as defined in IndexDefinition

{code}
this.blobSize = getOptionalValue(defn, BLOB_SIZE, DEFAULT_BLOB_SIZE);
{code}

And then in OakDirectory while creating any new index file logic checks for the 
default value from {{IndexDefinition}}

{code}
    @Override
    public IndexOutput createOutput(String name, IOContext context)
            throws IOException {
        checkArgument(!readOnly, "Read only directory");
        NodeBuilder file;
        if (!directoryBuilder.hasChildNode(name)) {
            file = directoryBuilder.child(name);
            file.setProperty(PROP_BLOB_SIZE, definition.getBlobSize());
        } else {
            file = directoryBuilder.child(name);
        }
        fileNames.add(name);
        return new OakIndexOutput(name, file);
    }
{code}

> Change default maxCachedBinarySize to match OakDirectory#DEFAULT_BLOB_SIZE
> --------------------------------------------------------------------------
>
>                 Key: OAK-3231
>                 URL: https://issues.apache.org/jira/browse/OAK-3231
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: blob
>            Reporter: Amit Jain
>            Assignee: Amit Jain
>            Priority: Minor
>
> The default for {{DataStoreBlobStore#maxCachedBinarySize}} was supposed to be 
> equal or greater than OakDirectory#DEFAULT_BLOB_SIZE. That default was 
> increased to 32 * 1024 while here the default is still set to 17 * 1024. 
> We should increase the default to 33 * 1024 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)