[ 
https://issues.apache.org/jira/browse/OAK-3294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14713049#comment-14713049
 ] 

Michael Dürig commented on OAK-3294:
------------------------------------

Looks good AFAICS. 

I don't like all the {{if(readonly)}} in the {{FileStore}} constructor though. 
But I neither have a better solution ATM. To get rid of them we probably need a 
quite deep refactoring. 

About those {{closeQuietly}}, I'd prefer something like {{closeAndLogOnFail}}. 

> Read-only live FileStore implementation
> ---------------------------------------
>
>                 Key: OAK-3294
>                 URL: https://issues.apache.org/jira/browse/OAK-3294
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: segmentmk
>            Reporter: Alex Parvulescu
>            Assignee: Alex Parvulescu
>            Priority: Minor
>         Attachments: OAK-3294.patch
>
>
> Having a read-only FileStore able to work on a running (live) FileStore would 
> open the door for some interesting data collection & debugging tools that no 
> longer need the repository to be shut down.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to