[ 
https://issues.apache.org/jira/browse/OAK-3309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alex Parvulescu updated OAK-3309:
---------------------------------
    Attachment: OAK-3309.patch

proposed patch!

changes
 - added a weigher based on the segment.size
 - each segment load operation will go through the loader now, so stats will be 
recorded (even if the segment read operations are sampled from the cache)
 - thanks to the weigher the segment cache mbean can now also provide a sample 
of how full the cache is vs. its max size

I observed a change in behavior wrt. what I remember from a while back before 
the current cache was introduced: the bulk segments were not cached, just the 
data ones. any ideas why this changed? I left a TODO in the code about this, 
apologies if this was already discussed and I missed it.

[~mduerig], [~frm] feedback appreciated!


> SegmentMK segment cache loader stats
> ------------------------------------
>
>                 Key: OAK-3309
>                 URL: https://issues.apache.org/jira/browse/OAK-3309
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: segmentmk
>            Reporter: Alex Parvulescu
>            Assignee: Alex Parvulescu
>         Attachments: OAK-3309.patch
>
>
> The existing Segment Cache has no loading-related stats, I'd like to see how 
> complicated it would be to add some.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to