[ 
https://issues.apache.org/jira/browse/OAK-2849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14716862#comment-14716862
 ] 

Alex Parvulescu commented on OAK-2849:
--------------------------------------

Another question about the _SegmentCompactionIT_, I'm starting a different 
thread so the discussion doesn't get mixed.
I'm seeing a lot of uncollected tar files having references coming in from 
properties added on the root [0]. Thinking of this scenario I'm actually 
wondering if this is properly supported by the current compaction code or not. 
properties on the root are not very common so it might happen that we simply 
missed covering them in the code so far.

[0]
{code}
SegmentNodeState references to 
oak-core/target/SegmentCompactionIT7541916973060499313dir/data00007b.tar
In Memory segment references: 
[770d0483-4a80-4289-b68f-ac2135d754d8, 66ace420-6e04-49db-b436-f2e8b55ba4c6, 
b80e76e9-df2f-463a-b78f-3e15a0044d21, cc2a5afc-9b92-4413-bfc0-d8b710b279f7]
Repository content references:
/root/@BW2298 = {36958 bytes} 
[SegmentPropertyState@eb5c4133-7729-45d9-adfe-9a8a3e4e8be3.ce72]
/root/@BW2311 = {488639 bytes} 
[SegmentPropertyState@eb5c4133-7729-45d9-adfe-9a8a3e4e8be3.cd29]
/root/@BW2419 = {159517 bytes} 
[SegmentPropertyState@eb5c4133-7729-45d9-adfe-9a8a3e4e8be3.ccf3]
{code}

> Improve revision gc on SegmentMK
> --------------------------------
>
>                 Key: OAK-2849
>                 URL: https://issues.apache.org/jira/browse/OAK-2849
>             Project: Jackrabbit Oak
>          Issue Type: Task
>          Components: segmentmk
>            Reporter: Michael Dürig
>            Assignee: Michael Dürig
>              Labels: compaction, gc
>             Fix For: 1.3.6
>
>         Attachments: SegmentCompactionIT-conflicts.png
>
>
> This is a container issue for the ongoing effort to improve revision gc of 
> the SegmentMK. 
> I'm exploring 
> * ways to make the reference graph as exact as possible and necessary: it 
> should not contain segments that are not referenceable any more and but must 
> contain all segments that are referenceable. 
> * ways to segregate the reference graph reducing dependencies between certain 
> set of segments as much as possible. 
> * Reducing the number of in memory references and their impact on gc as much 
> as possible.
> Work in progress is in my private [Github 
> fork|https://github.com/mduerig/jackrabbit-oak]. As soon as something is 
> promising enough to make it into Oak, I spawn of an issue an make it a 
> subtask of this task. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to