[ 
https://issues.apache.org/jira/browse/OAK-3418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated OAK-3418:
--------------------------------
    Attachment: OAK-3418.diff

Proposed patch. It (a) skips zero-length hardware addresses, and (b) 
prioritizes hardware addresses with length == 6 over others, so that the 
windows-specific 00000000e000 is not used.

This solves my immediate problem on Windows and doesn't seem to make too 
strange assumptions, so I'd propose to use this for now.

[~tmueller], [~egli], can you review?

> ClusterNodeInfo uses irrelevant network interface IDs on Windows
> ----------------------------------------------------------------
>
>                 Key: OAK-3418
>                 URL: https://issues.apache.org/jira/browse/OAK-3418
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: core
>            Reporter: Julian Reschke
>            Assignee: Thomas Mueller
>              Labels: resilience
>             Fix For: 1.3.7
>
>         Attachments: OAK-3418.diff
>
>
> On Windows, all kinds of adapters (tunnel, VPN) return a hardware address of 
> 00-00-00-00-00-00-00-E0 (note 8 bytes, not 6). These addresses are useless 
> for the identification of the machine, however they get used because they are 
> the lowest value.
> A potential fix is to change the validity check to:
> if (mac != null && mac.length == 6)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to