[ 
https://issues.apache.org/jira/browse/OAK-3449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14910146#comment-14910146
 ] 

Julian Reschke commented on OAK-3449:
-------------------------------------

Let's consider the problem the hardwired clusterId is supposed to solve: 
running two instances from the same machine/instance. I believe we can achieve 
this if the code that instantiates the node store can supply additional 
information that's sufficient to disambiguate from other instances.

So how about allowing the caller to specify the instanceId (which currently 
defaults to the working directory) instead?

> DocumentNodeStore support for predefined clusterIds should use 
> ClusterNodeInfos
> -------------------------------------------------------------------------------
>
>                 Key: OAK-3449
>                 URL: https://issues.apache.org/jira/browse/OAK-3449
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core, mongomk, rdbmk
>            Reporter: Julian Reschke
>            Assignee: Julian Reschke
>              Labels: test
>         Attachments: cid.diff
>
>
> We currently support explicit assignment of clusterId 
> (builder.setClusterId()). In this case, DocumentNodeStore uses the specified 
> cluster id and skips all code related to creating/maintaining 
> ClusterNodeInfos.
> This feature is mainly (only?) used for testing (mainly allowing multiple 
> instances to run from the same machine/instance combination). This works, but 
> causes the logic related to ClusterNodeInfo not to be used at all (for 
> instance, LastRevRecovery).
> So we ought to change this config option to use ClusterNodeInfo in a way that 
> is at least similar to real-world use.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to