[
https://issues.apache.org/jira/browse/OAK-3311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14936844#comment-14936844
]
angela commented on OAK-3311:
-----------------------------
some comments on the patch:
- it replaces {{<version>${project.version}</version>}} by
{{<version>1.0.19</version>}}. i think that's a left over and should not applied
- it just catches {{Exception}} in may places, which is IMHO pretty bad
practise and not suited to address the NPE. proper annotation and defensive
tests for possible null would be better.
- {{toString}} method unrelated to the issue in my opinion
- missing test-case verifying that the issue is actually valid and that the
patch actually addresses it.
i think a little bit more work is needed here to have a proper fix for the
issue at hand.
> Potential NPE in syncAllExternalUsers() aborts the process
> ----------------------------------------------------------
>
> Key: OAK-3311
> URL: https://issues.apache.org/jira/browse/OAK-3311
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: auth-external
> Affects Versions: 1.2.4, 1.3.4, 1.0.19
> Reporter: Tobias Bocanegra
> Assignee: Tobias Bocanegra
> Attachments: OAK-3311-1.0.19.patch
>
>
> The iteration over all users in {{syncAllExternalUsers()}} aborts if there is
> an uncaught NPE.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
