[
https://issues.apache.org/jira/browse/OAK-3329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14943170#comment-14943170
]
Alex Parvulescu edited comment on OAK-3329 at 10/5/15 10:14 AM:
----------------------------------------------------------------
+1 looks good to me.
one area where we could improve is the file deletion clarification:
* first the message 'TarMK revision cleanup reclaiming _file name_' could
probably be 'marking _file_ for deletion' as the actual deletion happens later.
[0]
* second the deletion itself could probably log the warning when it cannot
delete an existing file [1]
[0]
https://github.com/apache/jackrabbit-oak/blob/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/segment/file/FileStore.java#L743
[1]
https://github.com/apache/jackrabbit-oak/blob/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/segment/file/FileStore.java#L691
was (Author: alex.parvulescu):
+1 looks good to me.
one area where we could improve is the file deletion clarification:
* first the message "TarMK revision cleanup reclaiming {file name}" could
probably be 'marking {file} for deletion' as the actual deletion happens later.
[0]
* second the deletion itself could probably log the warning when it cannot
delete an existing file [1]
[0]
https://github.com/apache/jackrabbit-oak/blob/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/segment/file/FileStore.java#L743
[1]
https://github.com/apache/jackrabbit-oak/blob/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/segment/file/FileStore.java#L691
> TarMK cleanup blocks writers
> ----------------------------
>
> Key: OAK-3329
> URL: https://issues.apache.org/jira/browse/OAK-3329
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: segmentmk
> Reporter: Michael Dürig
> Assignee: Michael Dürig
> Labels: cleanup, gc
> Fix For: 1.3.8
>
> Attachments: OAK-3329.patch, base.png, patched.png
>
>
> TarMK cleanup exclusively locks the {{FileStore}}, which causes concurrent
> writers to block until cleanup finished. Initially cleanup was expected to be
> reasonably fast, however I have seen it taking dozens of minutes under
> certain circumstances (most likely many tar files with many small segments,
> aka OAK-2896).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
