[ 
https://issues.apache.org/jira/browse/OAK-3479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14944761#comment-14944761
 ] 

Michael Dürig commented on OAK-3479:
------------------------------------

Patch looks good. 

bq. newly formed SegmentIds can be assigned the current generation

I experimented with something along these lines earlier and found in very 
tricky to catch the right generation. The problem is with segments generated by 
compaction itself, re-loading of older segments etc. But still think its worth 
to take another stab at this. 

> Add generation info to compaction map
> -------------------------------------
>
>                 Key: OAK-3479
>                 URL: https://issues.apache.org/jira/browse/OAK-3479
>             Project: Jackrabbit Oak
>          Issue Type: Technical task
>          Components: segmentmk
>            Reporter: Alex Parvulescu
>            Assignee: Alex Parvulescu
>            Priority: Minor
>              Labels: cleanup, compaction, gc
>             Fix For: 1.3.8
>
>         Attachments: OAK-3479.patch
>
>
> I'd like to add a counter that exposes the current generation of the 
> compaction map, (meaning the number of compaction cycles).
> So far I've been using the CompactionMap#getDepth as a heuristic but if you 
> run long enough some old generations will be dropped decreasing the depth, 
> making it unreliable as a generation counter.
> I don't want to persist this info, just start at 0 once the system starts up 
> and increase on each CompactionMap#cons call.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to