[
https://issues.apache.org/jira/browse/OAK-2879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14945056#comment-14945056
]
Francesco Mari commented on OAK-2879:
-------------------------------------
bq. FileStore#newCancelCompactionCondition looks funny though: hit = hit,
something got probably lost there.
This is just me being too clever and harming readability. The idea was to
implement a "sticky" flag. If the {{hit}} flag is {{true}} once, it will stay
{{true}} even if its underlying condition (in this case,
{{!sufficientDiskSpace.get()}}) changes over time. I will make this piece of
code more readable before committing.
> Compaction should check for required disk space before running
> --------------------------------------------------------------
>
> Key: OAK-2879
> URL: https://issues.apache.org/jira/browse/OAK-2879
> Project: Jackrabbit Oak
> Issue Type: Sub-task
> Components: segmentmk
> Reporter: Michael Dürig
> Assignee: Francesco Mari
> Labels: compaction, doc-impacting, gc, resilience
> Fix For: 1.3.8
>
> Attachments: OAK-2879-01.patch, OAK-2879-02.patch, OAK-2879-03.patch
>
>
> In the worst case compaction doubles the repository size while running. As
> this is somewhat unexpected we should check whether there is enough free disk
> space before running compaction and log a warning otherwise. This is to avoid
> a common source of running out of disk space and ending up with a corrupted
> repository.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
