[
https://issues.apache.org/jira/browse/OAK-3513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14956483#comment-14956483
]
Ian Boston commented on OAK-3513:
---------------------------------
The patch fixes this issue, but does not eliminate the impact of the reindex
flag if, for whatever reason, it is persisted into the repository. Since that
flag being persisted to the repository, makes the repository unavailable,
perhaps that should be eliminated ?
It is valid to argue that the flag will never be persisted to the repository if
the risk of that happening is absolutely zero, but that was argued before this
issue was opened, evidenced by the code that set the flag.
Should the commit hook that intercepts the flag and performs reindexing ever
fail for whatever reason, the flag will get committed. imvho it would be better
to check the NodeBuilder before and after to make certain the flag when true,
is not true in the repository, as that is afaict the real desired behaviour of
re-indexing.
> Session save going through despite repository being shutdown causing reindex
> flag to reset
> ------------------------------------------------------------------------------------------
>
> Key: OAK-3513
> URL: https://issues.apache.org/jira/browse/OAK-3513
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: core
> Reporter: Chetan Mehrotra
> Priority: Minor
> Fix For: 1.3.9, 1.0.23, 1.2.8
>
> Attachments: OAK-3513-1.patch
>
>
> In some scenarios it can happen then repository instance has been shutdown
> and removed from OSGi service registry but NodeStore is still active. In such
> case if any thread has access to a JCR session instance then any commit done
> via that session would still go through.
> This causes issues as upon repository shutdown the whiteboard based trackers
> would have lost any editor, validators and hence such commit can lead to
> invalid data being committed.
> Also in some cases it can lead to reindex flag for various sync indexes
> getting reset to true as backing index editors are not present during the
> commit
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
