[
https://issues.apache.org/jira/browse/OAK-3519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
angela updated OAK-3519:
------------------------
Attachment: OAK-3519_2.patch
updated patch fixes a missing Session.logout call in the initial patch and
additionally provides an initial stub to write test for the jmx-sync
implementation; further improvements: moving out the {{Delegatee}} inner class
out for better readability, minor renaming/restructuring of the report
generation.
> Some improvement to SyncMBeanImpl
> ---------------------------------
>
> Key: OAK-3519
> URL: https://issues.apache.org/jira/browse/OAK-3519
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: auth-external
> Reporter: angela
> Assignee: angela
> Priority: Minor
> Attachments: OAK-3519.patch, OAK-3519_2.patch
>
>
> IMHO the {{SyncMBeanImpl}} deserves some improvement:
> - code duplication
> - overall readability
> - removing catching {{Exception}}
> - throwing {{IllegalArgument}} when no argument has been provided instead of
> a dedicated {{RuntimeException}} indicating that the operation could not be
> successfully completed
> - more consistency in variable naming (e.g. the list of strings computed in
> the various operations is sometimes called {{list}} and sometimes {{result}})
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
