[ 
https://issues.apache.org/jira/browse/OAK-3522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14959084#comment-14959084
 ] 

angela commented on OAK-3522:
-----------------------------

btw: the same applies for the set of protected methods that deal with JCR-value 
creation/conversion. IMHO they don't belong to a public {{DefaultSyncContext}} 
class but should got into some value conversion/creation utility (and 
potentially already exist somewhere in oak-core).

> DefaultSyncContext exposes internal path-utility method
> -------------------------------------------------------
>
>                 Key: OAK-3522
>                 URL: https://issues.apache.org/jira/browse/OAK-3522
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: auth-external
>            Reporter: angela
>         Attachments: OAK-3522.patch
>
>
> the {{DefaultSyncContext}} defines a public static method {{joinPaths}}, 
> which IMHO should not be exposed as it is unrelated to the functionality 
> defined by the {{DefaultSyncContext}}.
> i would therefore suggest to make it private (and increase the package 
> version to 2.0.0)... we can then still decide to move this utility to 
> {{PathUtils}} in oak-commons.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to