[
https://issues.apache.org/jira/browse/OAK-3586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14989681#comment-14989681
]
Marcel Reutegger commented on OAK-3586:
---------------------------------------
Looks good in general. Some comments/questions:
- I would prefer a Set<Revision> for conflictRevisions in
CommitQueue.suspendUntilAll(). This makes sure we don't have duplicates in
conflictRevisions.
- Similar to above use a Set<Revision> in ConflictException and
FailedWithConflictException
- The first ConflictException constructor should say 'conflictRevision'
(singular).
- ConflictException.getConflictRevisions() is annotated with Nullable. I think
it should be NotNull. I would also turn the return type into a more general
Iterable<Revision>
- Change type of conflictRevisions parameter in
DocumentNodeStore.suspendUntilAll() to Set<Revision> as well?
- Can you please add tests to verify the correct behavior when multiple
conflict revisions are reported?
> ConflictException and CommitQueue should support a list of revisions
> --------------------------------------------------------------------
>
> Key: OAK-3586
> URL: https://issues.apache.org/jira/browse/OAK-3586
> Project: Jackrabbit Oak
> Issue Type: Technical task
> Components: core, documentmk
> Reporter: Tomek Rękawek
> Fix For: 1.4
>
>
> The OAK-3559 aims at providing bulk version of the
> {{DocumentStore#createOrUpdate()}}, so the {{Commit}} class can apply many
> changes at the same time. If there's a conflict detected afterwards, it may
> involve many documents and revisions. That's why the {{ConflictException}}
> needs to be extended, so it can contain a revision list rather than a single
> revision.
> Once the {{ConflictException}} contains revision list, the
> {{CommitQueue#suspendUntil()}} method should be updated as well, to suspend
> thread until all revisions from the passed collection are visible and all
> conflicts are resolved.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
