[ 
https://issues.apache.org/jira/browse/OAK-3654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15021991#comment-15021991
 ] 

Chetan Mehrotra commented on OAK-3654:
--------------------------------------

bq. nanoTimer and performance. I have measured the overhead of the metrics 
library to be about 10% timing calls of about 1E-7s.

[~ianeboston] Coming on this again. Oak has a Clock.Fast implementation as it 
was observed that fetching nanoTime can lead to slowdown on some setup. See 
[discussion in 
OAK-1418|https://issues.apache.org/jira/browse/OAK-1418?focusedCommentId=13923093&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13923093]
 for more details. I would try to run a benchmark and see if the number are bad 
or good. However it very much depend on hardware so might not get detected. 

As metrics has a Clock abstraction we can provide our own implementation there 
based 
[Clock.Fast|https://github.com/apache/jackrabbit-oak/blob/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/stats/Clock.java#L280].
 Thoughts?

> Integrate with Metrics for various stats collection 
> ----------------------------------------------------
>
>                 Key: OAK-3654
>                 URL: https://issues.apache.org/jira/browse/OAK-3654
>             Project: Jackrabbit Oak
>          Issue Type: New Feature
>          Components: core
>            Reporter: Chetan Mehrotra
>            Assignee: Chetan Mehrotra
>             Fix For: 1.4
>
>         Attachments: OAK-3654-v1.patch, query-stats.png
>
>
> As suggested by [~ianeboston] in OAK-3478 current approach of collecting 
> TimeSeries data is not easily consumable by other monitoring systems. Also 
> just extracting the last moment data and exposing it in simple form would not 
> be useful. 
> Instead of that we should look into using Metrics library [1] for collecting 
> metrics. To avoid having dependency on Metrics API all over in Oak we can 
> come up with minimal interfaces which can be used in Oak and then provide an 
> implementation backed by Metric.
> This task is meant to explore that aspect and come up with proposed changes 
> to see if its feasible to make this change
> * metrics-core ~100KB in size with no dependency
> * ASL Licensee
> [1] http://metrics.dropwizard.io



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to