[ 
https://issues.apache.org/jira/browse/OAK-3654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15024451#comment-15024451
 ] 

Chetan Mehrotra commented on OAK-3654:
--------------------------------------

Modified the logic to allow disabling the Timers but keep the meters. Benchmark 
numbers improved but still slower

{noformat}
Apache Jackrabbit Oak 1.4-SNAPSHOT
# ReadPropertyTest                 C     min     10%     50%     90%     max    
   N
Oak-Tar                            1       6       6       6       7      24    
9352
Oak-Tar (1.3.11                    1       6       6       6       9      35    
8576
Oak-Tar (Metrics Enabled)          1      12      12      12      14      30    
4711
Oak-Tar (Only Meters Enabled)      1       8       8       9      10      29    
6536
{noformat}

With stats dumped
{noformat}
Apache Jackrabbit Oak 1.4-SNAPSHOT
# ReadPropertyTest                 C     min     10%     50%     90%     max    
   N
18:16:26.568 [main] INFO  o.a.j.oak.benchmark.ReadPropertyTest - Enabling 
Metrics integration
18:16:56.602 [metrics-logger-reporter-1-thread-1] INFO  
org.apache.jackrabbit.oak.metrics - type=GAUGE, name=SESSION_READ_AVERAGE, 
value=NaN
18:16:56.603 [metrics-logger-reporter-1-thread-1] INFO  
org.apache.jackrabbit.oak.metrics - type=METER, name=SESSION_READ_COUNTER, 
count=88118043, mean_rate=2935927.5911976863, m1=2108413.9925555317, 
m5=1666734.3265087851, m15=1578093.5724496346, rate_unit=events/second
18:16:56.604 [metrics-logger-reporter-1-thread-1] INFO  
org.apache.jackrabbit.oak.metrics - type=TIMER, name=SESSION_READ_DURATION, 
count=0, min=0.0, max=0.0, mean=0.0, stddev=0.0, median=0.0, p75=0.0, p95=0.0, 
p98=0.0, p99=0.0, p999=0.0, mean_rate=0.0, m1=0.0, m5=0.0, m15=0.0, 
rate_unit=events/second, duration_unit=microseconds
18:17:26.601 [metrics-logger-reporter-1-thread-1] INFO  
org.apache.jackrabbit.oak.metrics - type=GAUGE, name=SESSION_READ_AVERAGE, 
value=NaN
18:17:26.602 [metrics-logger-reporter-1-thread-1] INFO  
org.apache.jackrabbit.oak.metrics - type=METER, name=SESSION_READ_COUNTER, 
count=187182491, mean_rate=3119082.720643154, m1=2574520.692012776, 
m5=1822207.3237623086, m15=1634602.3663047573, rate_unit=events/second
18:17:26.602 [metrics-logger-reporter-1-thread-1] INFO  
org.apache.jackrabbit.oak.metrics - type=TIMER, name=SESSION_READ_DURATION, 
count=0, min=0.0, max=0.0, mean=0.0, stddev=0.0, median=0.0, p75=0.0, p95=0.0, 
p98=0.0, p99=0.0, p999=0.0, mean_rate=0.0, m1=0.0, m5=0.0, m15=0.0, 
rate_unit=events/second, duration_unit=microseconds
Oak-Tar                            1       8       8       9      10      29    
6536
{noformat}

So looks like we would need to disable the Metrics support for both read and 
write and just live with default support as currently present

> Integrate with Metrics for various stats collection 
> ----------------------------------------------------
>
>                 Key: OAK-3654
>                 URL: https://issues.apache.org/jira/browse/OAK-3654
>             Project: Jackrabbit Oak
>          Issue Type: New Feature
>          Components: core
>            Reporter: Chetan Mehrotra
>            Assignee: Chetan Mehrotra
>             Fix For: 1.3.12
>
>         Attachments: OAK-3654-v1.patch, query-stats.png
>
>
> As suggested by [~ianeboston] in OAK-3478 current approach of collecting 
> TimeSeries data is not easily consumable by other monitoring systems. Also 
> just extracting the last moment data and exposing it in simple form would not 
> be useful. 
> Instead of that we should look into using Metrics library [1] for collecting 
> metrics. To avoid having dependency on Metrics API all over in Oak we can 
> come up with minimal interfaces which can be used in Oak and then provide an 
> implementation backed by Metric.
> This task is meant to explore that aspect and come up with proposed changes 
> to see if its feasible to make this change
> * metrics-core ~100KB in size with no dependency
> * ASL Licensee
> [1] http://metrics.dropwizard.io



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to