[
https://issues.apache.org/jira/browse/OAK-3654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chetan Mehrotra updated OAK-3654:
---------------------------------
Attachment: OAK-3654-fast-clock.patch
[patch|^OAK-3654-fast-clock.patch] which uses fast clock from Oak only for
Meters. With this the timing got better
{noformat}
Apache Jackrabbit Oak 1.4-SNAPSHOT
# ReadPropertyTest C min 10% 50% 90% max
N
Oak-Tar 1 6 6 6 7 24
9352
Oak-Tar (1.3.11 1 6 6 6 9 35
8576
Oak-Tar (Metrics Enabled) 1 12 12 12 14 30
4711
Oak-Tar (Only Meters Enabled) 1 8 8 9 10 29
6536
Oak-Tar (Only Meters + Fast Clock) 1 6 7 7 8 18
7959
{noformat}
Result with report logging
{noformat}
Apache Jackrabbit Oak 1.4-SNAPSHOT
# ReadPropertyTest C min 10% 50% 90% max
N
22:20:20.763 [main] INFO o.a.j.oak.benchmark.ReadPropertyTest - Enabling
Metrics integration
22:20:50.801 [metrics-logger-reporter-1-thread-1] INFO
org.apache.jackrabbit.oak.metrics - type=METER, name=SESSION_READ_COUNTER,
count=111845099, mean_rate=3984507.730673317, m1=3773353.4042265792,
m5=3687796.0963687506, m15=3671206.6599464254, rate_unit=events/second
22:21:20.801 [metrics-logger-reporter-1-thread-1] INFO
org.apache.jackrabbit.oak.metrics - type=METER, name=SESSION_READ_COUNTER,
count=229249461, mean_rate=3947812.467711383, m1=3830433.1881985296,
m5=3710874.9613871695, m15=3679766.0272796173, rate_unit=events/second
Oak-Tar 1 6 7 7 8 18
7959
{noformat}
[~ianeboston]
[Meter|https://github.com/dropwizard/metrics/blob/master/metrics-core/src/main/java/io/dropwizard/metrics/Meter.java]
uses Clock to determine if 5 sec tick interval has passed or not. For such a
case I think Fast clock should be fine
Otherwise we can restrict the Fast clock for such time critical meters.
Thoughts?
> Integrate with Metrics for various stats collection
> ----------------------------------------------------
>
> Key: OAK-3654
> URL: https://issues.apache.org/jira/browse/OAK-3654
> Project: Jackrabbit Oak
> Issue Type: New Feature
> Components: core
> Reporter: Chetan Mehrotra
> Assignee: Chetan Mehrotra
> Fix For: 1.3.12
>
> Attachments: OAK-3654-fast-clock.patch, OAK-3654-v1.patch,
> query-stats.png
>
>
> As suggested by [~ianeboston] in OAK-3478 current approach of collecting
> TimeSeries data is not easily consumable by other monitoring systems. Also
> just extracting the last moment data and exposing it in simple form would not
> be useful.
> Instead of that we should look into using Metrics library [1] for collecting
> metrics. To avoid having dependency on Metrics API all over in Oak we can
> come up with minimal interfaces which can be used in Oak and then provide an
> implementation backed by Metric.
> This task is meant to explore that aspect and come up with proposed changes
> to see if its feasible to make this change
> * metrics-core ~100KB in size with no dependency
> * ASL Licensee
> [1] http://metrics.dropwizard.io
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
