[
https://issues.apache.org/jira/browse/OAK-3685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15031820#comment-15031820
]
Julian Sedding edited comment on OAK-3685 at 11/30/15 2:23 PM:
---------------------------------------------------------------
[~tomek.rekawek] Thanks for the PR. I have a few comments:
- What is the use-case for STRIP_VALUE_PATTERN and the related logic? This is
not apparent from either the issue or the patch.
- I don't like where we are headed with {{\-\-src-fileblobstore}},
{{\-\-src-datastore}}, {{\-\-src-s3datastore}}. Wouldn't it make more sense to
have a single argument, e.g. {{\-\-src-blobstore}}, and either infer the
correct implementation from the passed value, or specify the type via a second
parameter, e.g. {{\-\-src-blobstore-type=s3}}. Thoughts?
was (Author: jsedding):
[~tomek.rekawek] Thanks for the PR. I have a few comments:
- What is the use-case for STRIP_VALUE_PATTERN and the related logic? This is
not apparent from either the issue or the patch.
- I don't like where we are headed with {{--src-fileblobstore}},
{{--src-datastore}}, {{--src-s3datastore}}. Wouldn't it make more sense to have
a single argument, e.g. {{--src-blobstore}}, and either infer the correct
implementation from the passed value, or specify the type via a second
parameter, e.g. {{--src-blobstore-type=s3}}. Thoughts?
> Support S3DataSource as the migration source
> --------------------------------------------
>
> Key: OAK-3685
> URL: https://issues.apache.org/jira/browse/OAK-3685
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: upgrade
> Reporter: Tomek Rękawek
> Priority: Minor
> Fix For: 1.3.12
>
>
> In the current version, oak-upgrade doesn't support migrations from a
> SegmentNodeStore or DocumentNodeStore with S3DataStore. Because some of the
> S3DataStore users requests the possiblity of doing sidegrade (eg. from
> SegmentNodeStore to Mongo), appropriate option should be added.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
