[ 
https://issues.apache.org/jira/browse/OAK-3738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15046644#comment-15046644
 ] 

Julian Sedding commented on OAK-3738:
-------------------------------------

[~tomek.rekawek] I am a bit surprised that you are reporting a crx2oak issue in 
the Oak issue tracker. I was even more surprised that the implementation 
visible in the patch (both old and new) has several references to crx2. Last 
time I checked CRX was a commercial product by Adobe.

Furthermore, I don't think the "inplace upgrade" scenario has much value for a 
Jackrabbit 2 to Oak upgrade, because (a) data typically lives in a RDB and (b) 
the directory structure varies due to {{repository.xml}} and {{workspace.xml}} 
configurations. Implementing support for CRX conventions should therefore be a 
concern for crx2oak, not for oak-upgrade.

Therefore I suggest we close this issue "won't fix" and create a new issue to 
remove "inplace upgrade" support (and all references to CRX) in {{oak-upgrade}}.

> Datastore directory shouldn't be moved after the migration
> ----------------------------------------------------------
>
>                 Key: OAK-3738
>                 URL: https://issues.apache.org/jira/browse/OAK-3738
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: upgrade
>            Reporter: Tomek Rękawek
>            Priority: Minor
>             Fix For: 1.4
>
>         Attachments: OAK-3738.patch
>
>
> After the in-place upgrade is finished, crx2oak moves all the CRX2 files into 
> {{repository/crx2}} directory. This includes {{datastore}} directory, which 
> may be reused by the Oak repository. Therefore, it shouldn't be moved if the 
> {{--copy-binaries}} flag is not present.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to