[ 
https://issues.apache.org/jira/browse/OAK-3529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Davide Giannella updated OAK-3529:
----------------------------------
    Attachment: OAK-3529-5.patch

Attaching a [new patch|^OAK-3529-5.patch] where I removed the
getInstaceId from the builders.

The Jcr builder now keep tracks of the instanceId and NodeStore.

I personally don't like it and I think we should address the situation
by adding a new {{.with(@Nonnull Clusterable)}}. The Clusterable
aspect could be implemented by something different than a
NodeStore. In particular deployments for example someone could create
a "service" that delegates it to Sling rather than our NodeStore or we
could come up with type of Topology which we could later on leverage.

By specifying the new .with() we make it clear from a repository
construction POV.

This new {{.with()}} can be addressed later on with a separate issue.

[~mduerig], [~mreutegg] please review

> NodeStore API should expose an Instance ID
> ------------------------------------------
>
>                 Key: OAK-3529
>                 URL: https://issues.apache.org/jira/browse/OAK-3529
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core
>            Reporter: Davide Giannella
>            Assignee: Davide Giannella
>             Fix For: 1.4
>
>         Attachments: OAK-3529-1.patch, OAK-3529-2.patch, OAK-3529-3.patch, 
> OAK-3529-4.patch, OAK-3529-5.patch
>
>
> For better leveraging cluster oriented algorithm: discovery, atomic
> operations; it would be very helpful if the NodeStore could expose a
> unique instance id.
> This can be the same as a cluster ID.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to